fixes bug with duplicate guidance and adds rake task to cleanup database#584
Merged
vyruss merged 2 commits intoAug 15, 2017
Merged
Conversation
vyruss
approved these changes
Aug 15, 2017
Contributor
Author
|
hadnt saved most current version of lib/tasks/migrate.rake file |
vyruss
approved these changes
Aug 15, 2017
johnpinto1
pushed a commit
to DigitalCurationCentre/roadmap
that referenced
this pull request
Sep 7, 2021
…nt that does not provide a dropdown for funders. Changes: TO BE FILLED IN.
johnpinto1
pushed a commit
that referenced
this pull request
Sep 13, 2021
…an wizard page is completed"
Changes:
- In plans_controller.rb: save funder selected in
- added funders to show() method for the use by the partial
"shared/org_selectors/local_only" in _project_details.html.erb
- update() method changed to receive params for funder
- In _project_details.html.erb added "shared/org_selectors/local_only"
for funders.
briri
added a commit
that referenced
this pull request
Sep 13, 2021
…funder_once_plan_creation_wizard_completes Issue #584 - Fix for "Not possible to add funder once the creation pl…
portagenetwork
referenced
this pull request
in portagenetwork/roadmap
Feb 24, 2022
…an wizard page is completed"
Changes:
- In plans_controller.rb: save funder selected in
- added funders to show() method for the use by the partial
"shared/org_selectors/local_only" in _project_details.html.erb
- update() method changed to receive params for funder
- In _project_details.html.erb added "shared/org_selectors/local_only"
for funders.
portagenetwork
referenced
this pull request
in portagenetwork/roadmap
Feb 24, 2022
…le_to_add_funder_once_plan_creation_wizard_completes Issue #584 - Fix for "Not possible to add funder once the creation pl…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
original issue:
code which applies customizer's customizations to an updated base template copying over all guidance, not just that of the customizer, this caused duplicate funder guidance.
bugfix:
only copy over the current user's org's annotations
data correction:
rake task added to remove all these duplicate annotations from the codebase
rake migrate:remove_duplicate_annotations
Also looks like the editor i've switched to, atom.io, has ripped trailing whitespace out of saved files